You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This causes test/parallel/test-npm-version.js to fail. A seeming purpose of that test is to make sure we don't land npm rc's/betas/etc. Rather than altering the test, I think the thing to do is add an entry to test/parallel/parallel.status that turns the test yellow when it fails rather than red. This way, there's a clear indication in the CI that the code is not yet ready for release, but it won't stop other code from landing due to CI failing.
I think it would look like this:
[true] # This section applies to all platforms
# We temporarily have a npm rc. Allow test-npm-version to fail until it is
# removed.
# https://github.com/nodejs/node/pull/35447
test-npm-version: FLAKY
By using FLAKY and not PASS,FLAKY, I think the test will be required to fail. That will remind us to undo this when npm 7 is released for reals.
Another (perhaps simpler?) approach might be to move the test to test/known_issues where it will also be required to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmIssues and PRs related to the npm client dependency or the npm registry.semver-majorPRs that contain breaking changes and should be released in the next major version.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been awhile... reference to the
7.0.0-rc.0specific release notes: https://github.com/npm/cli/releases/tag/v7.0.0-rc.0 & correspondingv7CHANGELOG.md